Working around IE8's broken Object.defineProperty implementation

Question

Consider the following code, using ECMAScript5's Object.defineProperty feature:

var sayHi = function(){ alert('hi'); }; var defineProperty = (typeof Object.defineProperty == 'function'); if (defineProperty) Object.defineProperty(Array.prototype,'sayHi',{value:sayHi}); else Array.prototype.sayHi = sayHi; var a = []; a.sayHi(); 

This works for Chrome and Firefox 4 (where defineProperty exists), and it works for Firefox 3.6 (where defineProperty does not exist). IE8, however, only partially supports defineProperty. As a result, it attempts to run the Object.defineProperty method, but then fails (with no error shown in the browser) and ceases to run all other JavaScript code on the page.

Is there a better way to detect and avoid IE8's broken implementation than:

if (defineProperty){   try{ Object.defineProperty(Array.prototype,'sayHi',{value:sayHi}); }catch(e){}; } if (!Array.prototype.sayHi) Array.prototype.sayHi = sayHi; 

For the curious, I'm using this in my ArraySetMath library to define non-enumerable array methods in those browsers that support this, with a fallback to enumerable methods for older browsers.

Answer 1

I don't think there's a better way than a direct feature test with try/catch. This is actually exactly what IE team itself recommends in this recent post on transitioning to ES5 API.

You can shorten the test to just something like Object.defineProperty({}, 'x', {}) (instead of using Array.prototype) but that's a minor quibble; your example tests exact functionality (and so has less chance of false positives).