Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Is BackgroundWorker's IsBusy same as "IsAlive"?

I am trying to figure out a way to verify that a BackgroundWorker thread is alive (i.e. still running. The thread is essentially implemented as a simple infinite loop:

while (AllConditionsMet())
{
  DoSomeMagic();
  Thread.Sleep(10000);
}

The closest thing to IsAlive() I found so far is the IsBusy property, but given that my thread Sleep()s most of the time, I am not sure whether this will do the job.

Can I count on IsBusy to do:

if (!myWorker.IsBusy)
  RestartWorker();

or am I calling for trouble?

like image 873
scatmoi Avatar asked Oct 30 '12 13:10

scatmoi


3 Answers

BackgroundWorker.IsBusy is true as long as the DoWork event handler is busy and the RunWorkerCompleted event handler hasn't been run yet. Do note the latter clause, the property does not tell you if your loop is active.

Furthermore, there's a fairly nasty race condition in your second snippet. IsBusy might be true in the if() statement but be false a nanosecond later. The kind of race that strikes once a month. The intent of the code is hard to fathom from the snippets so hard to give a workaround. Consider just always creating a new BGW object, that will never race. Also helps getting rid of that loop, a thread sleeping for 10 seconds is wasting a very expensive system resource on doing nothing. And it gums-up the threadpool scheduler.

like image 173
Hans Passant Avatar answered Sep 16 '22 16:09

Hans Passant


To make sure the Backgroundworker really stopped, you can kill it manually. Set yourBackgroundWorker.WorkerSupportsCancellation = true;. Then simply stop the Backgroundworker with:

yourBackgroundWorker.CancelAsync();

Still isBusy should be enough to detect a running/working instance of your BackgroundWorker.

like image 32
jAC Avatar answered Sep 20 '22 16:09

jAC


From the docs:

true, if the BackgroundWorker is running an asynchronous operation; otherwise, false.

Regardless if you sleep the worker thread or not, it's still doing something so using IsBusy should be fine.

like image 43
James Avatar answered Sep 16 '22 16:09

James