Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

XSS : Creating a javascript object using PHP's json_encode

Is this 100% safe against XSS? If not, can you please provide example bad string text showing me why it is not.

<html>
  <body>
    <script>
      <?php
        $bad = "some bad string.  please give example text that makes the below unsafe";
        echo "var a = ".json_encode($bad).";";
        echo "var b = ".json_encode(array($bad)).";";
      ?>
    </script>
  </body>
</html>

Thanks.
like image 376
user324289 Avatar asked May 06 '11 15:05

user324289


2 Answers

In short, it's safe. Possible XSS would require escaping from the javascript string (") or script (</script>). Both strings are properly escaped:

"          becomes  \"
</script>  becomes  <\/script>

This is the the part about direct injection. Your application should take in account that some array elements may be missing. Another possibility is that an array element is not the type you would expect (e.g., an array instead of a string)

like image 103
Lekensteyn Avatar answered Oct 13 '22 12:10

Lekensteyn


Definitely not!!!

Don't use json_encode to escape javascript.

for example:

json_encode<img src=# onerror=alert(1)>, this will escape nothing and output to brower. This is a xss.

use htmlspecialchars instead.

like image 26
gouchaoer Avatar answered Oct 13 '22 11:10

gouchaoer