Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

WPF CommandParameter binding and canExecute

I have a template for treeView item:

<HierarchicalDataTemplate x:Key="RatesTemplate">
    <StackPanel Orientation="Horizontal">
                        <TextBlock Text="{Binding Path=ID}"/>
                        <Button CommandParameter="{Binding Path=ID}" 
                                Command="{Binding ElementName=CalcEditView, Path=DataContext.Add}">Add</Button>                            
    </StackPanel>
</HierarchicalDataTemplate>

As a DataContext I have linq entity with ID not null field.

The problem is: if I use DelegateCommand 'Add' with CanExecutedMethod:

AddRate = new DelegateCommand<int?>(AddExecute,AddCanExecute);

its called only once and parameter is null (while textBlock shows proper ID value). CanExecute is called before ID property is called (checked with debugger). Seems like before binding to actual parameter wpf is invoking canExecute and forgets about it. Once binding finished and proper value loaded it doesn't call CanExecute again.

As a workaround I can use command with only execute delegate:

Add = new DelegateCommand<int?>(AddExecute);

AddExecute is invoked with correct ID value and is working perfectly. But I still want to use CanExecute functionality. Any ideas?

like image 627
Alexander Prooks Avatar asked Nov 17 '09 13:11

Alexander Prooks


2 Answers

In this scenario, it's better to call the RaiseCanExecuteChanged() on the property used as a parameter for the Command. In your case, it would be the ID property in your ViewModel (Or whichever DataContext you're using).

It would be something like this:

private int? _id;
public int? ID
{
    get { return _id; }
    set
    {
        _id = value;
        DelegateCommand<int?> command = ((SomeClass)CalcEditView.DataContext).Add;
        command.RaiseCanExecuteChanged();
    }
}

The effect will be the same as your solution, but it keeps the Command logic out of code-behind.

like image 106
almulo Avatar answered Sep 23 '22 16:09

almulo


You can try to use CommandManager.InvalidateRequerySuggested to force an update.

like image 21
bitbonk Avatar answered Sep 22 '22 16:09

bitbonk