This method:
boolean containsSmiley(String s) { if (s == null) { return false; } else { return s.contains(":)"); } }
can equivalently be written:
boolean containsSmiley(String s) { if (s == null) { return false; } return s.contains(":)"); }
In my experience, the second form is seen more often, especially in more complex methods (where there may be several such exit points), and the same is true for "throw" as well as "return". Yet the first form arguably makes the conditional structure of the code more explicit. Are there any reasons to prefer one over the other?
(Related: Should a function have only one return statement?)
Don't put an else right after a return. Delete the else, it's unnecessary and increases indentation level.
Also, you shouldn't refer to an if/else statement as a loop; it is a conditional statement. Loops are used to repeat a piece of code, whereas an if/else is executed only once.
When a return statement is used in a function body, the execution of the function is stopped. If specified, a given value is returned to the function caller.
It is sometimes said that a method should have only one return statement (i.e. one exit point) and that to code using more than one return per method is bad practice. It is claimed to be a risk to readability or a source of error. Sometimes this is even given the title of the “single exit point law”.
The else
in that case would be redundant, as well as create unnecessary extra indentation for the main code of the function.
In my experience, it depends on the code. If I'm 'guarding' against something, I'll do:
if (inputVar.isBad()) { return; } doThings();
The point is clear: If that statement is false, I don't want the function to continue.
On the other hand, there are some functions with multiple options, and in that case I would write it like this:
if (inputVar == thingOne) { doFirstThing(); } else if (inputVar == secondThing) { doSecondThing(); } else { doThirdThing(); }
Even though it could be written as:
if (inputVar == thingOne) { doFirstThing(); return; } if (inputVar == thingTwo) { doSecondThing(); return; } doThingThree(); return;
It really comes down to which way most clearly shows what the code is doing (not necessarily which bit of code is shortest or has the least indentation).
If you love us? You can donate to us via Paypal or buy me a coffee so we can maintain and grow! Thank you!
Donate Us With