Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

What does this (useless?) javascript code do?

While debugging a javascript code that uses jQuery I found the following code:

[0, 0].sort(function()
{
    baseHasDuplicate = false;
    return 0;
});

By my understanding of javascript this code will sort array containing two zeroes with comparison function that will always set a global variable and will return equality, which has same effect as baseHasDuplicate = false;.
Coming from a valued source I think I missed something. Did I miss something or is this a programming fail?

like image 763
Dani Avatar asked Aug 10 '10 03:08

Dani


1 Answers

As you can see here (chinese), this code might be used to test for Chrome. EDIT: see below for the complete story..

As explained in the article, what happens is that Chrome optimizes the ".sort(...)" method in such a way that the [0, 0].sort(...) call won't execute the given comparison function.

From the article, Chrome's implementation of ".sort(...)" is something like:

function sort(comparefn) {
  var custom_compare = (typeof(comparefn) === 'function');
  function Compare(x,y) {
    if (x === y) return 0;
    if (custom_compare) {
      return comparefn.call(null, x, y);
    }
    ...
}

As 0 === 0 is true, it won't call comparefn.

In the case of jQuery, it won't set the global variable baseHasDuplicate to false.


EDIT: if you browse Sizzle's source code, here for example (go to the yellow section under "Sizzle CSS Selector Engine", called "Sizzle variables"), you will find the following explanation:

var chunker = /((?:\((?:\([^()]+\)|[^()]+)+\)|\[(?:\[[^[\]]*\]|['"][^'"]*['"]|[^[\]'"]+)+\]|\\.|[^ >+~,(\[\\]+)+|[>+~])(\s*,\s*)?((?:.|\r|\n)*)/g,
        done = 0,
        toString = Object.prototype.toString,
        hasDuplicate = false,
        baseHasDuplicate = true;

// Here we check if the JavaScript engine is using some sort of
// optimization where it does not always call our comparision
// function. If that is the case, discard the hasDuplicate value.
//   Thus far that includes Google Chrome.
[0, 0].sort(function(){
        baseHasDuplicate = false;
        return 0;
});     

Looks demystified!

like image 167
Bruno Reis Avatar answered Nov 01 '22 20:11

Bruno Reis