Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

What does a red text-background mean in GitHub comparison view?

Tags:

github

diff

I created a pull request and was browsing through, the differences are shown with light red/green line-brackgrounds, but some text is bolded with a red text background...

Update: Image changed to show file with some highlighted comments and some not. GitHub comparison view showing text with red background

What does this mean?

like image 624
jhabbott Avatar asked Jun 05 '15 13:06

jhabbott


People also ask

What does red background mean in GitHub?

The red background-color is definitely being caused by the error-highlighting feature of GitHub's text editor/viewer.

What is red GitHub?

GitHub - red/red: Red is a next-generation programming language strongly inspired by Rebol, but with a broader field of usage thanks to its native-code compiler, from system programming to high-level scripting and cross-platform reactive GUI, while providing modern support for concurrency, all in a zero-install, zero- ...


2 Answers

The red background-color is definitely being caused by the error-highlighting feature of GitHub's text editor/viewer. You can find the same behaviour occurring to an intended block comment in another JSON file on GitHub:

Screenshot of syntax error highlighting in GitHub

As for your comment about some illegal characters not being highlighted: I also found that certain JSON errors aren't caught by GitHub's syntax processor. See this gist as an example:

Example of uncaught errors in syntax highlighting

In this case, the text outside of the outermost object isn't being highlighted. Whatever reason there is for this may be the same reason that errors aren't being highlighted for you.

You can test it out for yourself by copy-pasting your code into a new Gist. Note that the ACE Editor has its own highlighting feature that can highlight code as you type, but its processing rules seem to be a bit different from that of GitHub's code viewer.

like image 145
ttton Avatar answered Oct 02 '22 07:10

ttton


This is issue makes code review process hard especially for the React(JSX) projects. Almost all the files with JSX showed the red lines.

I fixed it by copy pasting

var errorLine = document.getElementsByClassName("pl-ii"); var i; for (i = 0; i < errorLine.length; i++) {     errorLine[i].style.backgroundColor = "transparent";     errorLine[i].style.color = "#24292e"; } 

on my console

like image 20
Rohit Sthapit Avatar answered Oct 02 '22 07:10

Rohit Sthapit