Menu
On GitHub others can review your changes in your pull request and leave comments. When the comments have been attended to the author of the PR or those with write permissions can "Resolve conversation".
My question is: what is the correct etiquette here? So who should "Resolve conversation"?
Since the reviewer has left comments for changes, it would make sense to me that this person should resolve, since this person can judge best if his/her comments have been attended to.
But is this what is intended with the "Resolve conversation" button?
352
That is, if the last post was a comment or answer, then the recipient (who doesn't otherwise respond) should mark the conversation as resolved (as an acknowledgement of the last post and in lieu of any other response).
If the author of the PR comment is always the person who has the responsibility of marking that comment as resolved - this gets rid of this problem, and all changes will have had by at least two people's eyes on them.
To indicate that a conversation on the Files changed tab is complete, click Resolve conversation. The entire conversation will be collapsed and marked as resolved, making it easier to find conversations that still need to be addressed.
Always reply to every comment, regardless of whether it's a question or not. Reply with something like: “Will do,” “Done,” or “Good catch”.
The etiquette may change from project to project, so I don't think you'll find a "one size fits all" answer.
Personally, I like to reply to a comment and indicate that I've addressed it in a following revision of the PR (and if it's a non-trivial change, also explain how I addressed it), but leave it up to the reviewer to resolve the conversation. The way I see it, if a reviewer commented on my PR, it's up to them to also verify that the comment has been addressed, and mark the discussion as resolved if it was.
72
If you love us? You can donate to us via Paypal or buy me a coffee so we can maintain and grow! Thank you!
Donate Us With
