shared_ptr Assertion px != 0 failed

Question

I have a fairly complex multi threaded application (server) that from time to time will crash due to an assert:

/usr/include/boost/smart_ptr/shared_ptr.hpp:418: T* boost::shared_ptr< <template-parameter-1-1> >::operator->() const [with T = msg::Player]: Assertion `px != 0' failed.

I have been unable to pinpoint the cause and was wondering if this is a problem with boost::shared_ptr or it is me?

I tried g++ 4.4.3-4ubuntu5 and llvm-g++ (GCC) 4.2.1 with optimization and without optimization and libboost1.40-dev (= 1.40.0-4ubuntu4).

Answer 1

There should be no problem with using boost::shared_ptr as long as you initialize your shared pointers correctly and use the same memory management context for all your shared object libraries.

In your case you are trying to use an uninitialized shared pointer.

boost::shared_ptr<Obj> obj;
obj->Something(); // assertion failed

boost::shared_ptr<Obj> obj(new Obj);
obj->Something(); // ok

I would advise to initialize them right on declaration whenever possible. Exception handling can create a lot of "invisible" paths for the code to run and it might be quite difficult to identify the non initialized shared pointers.

PS: There are other issues if you load/unload modules where shared_ptr are in use leading to chaos. This is very hard to solve but in this case you would have a non zero pointer. This is not what is happening to you right now.

PPS: The pattern used is called RAII (Resource Acquisition Is Initialization)

Answer 2

you might want to make sure that you

always use a named smart pointer variable to hold the result of new

like it is recommended here: boost::shared_ptr - Best Practices

Regards, Jonny