This question is similar to How can I safely iterate a lua table while keys are being removed but distinctly different.
Given a Lua array (table with keys that are sequential integers starting at 1
), what's the best way to iterate through this array and delete some of the entries as they are seen?
I have an array of timestamped entries in a Lua array table. Entries are always added to the end of the array (using table.insert
).
local timestampedEvents = {} function addEvent( data ) table.insert( timestampedEvents, {getCurrentTime(),data} ) end
I need to occasionally run through this table (in order) and process-and-remove certain entries:
function processEventsBefore( timestamp ) for i,stamp in ipairs( timestampedEvents ) do if stamp[1] <= timestamp then processEventData( stamp[2] ) table.remove( timestampedEvents, i ) end end end
Unfortunately, the code above approach breaks iteration, skipping over some entries. Is there any better (less typing, but still safe) way to do this than manually walking the indices:
function processEventsBefore( timestamp ) local i = 1 while i <= #timestampedEvents do -- warning: do not cache the table length local stamp = timestampedEvents[i] if stamp[1] <= timestamp then processEventData( stamp[2] ) table.remove( timestampedEvents, i ) else i = i + 1 end end end
ArrayList provides the remove() methods, like remove (int index) and remove (Object element), you cannot use them to remove items while iterating over ArrayList in Java because they will throw ConcurrentModificationException if called during iteration.
If you want to delete elements from a list while iterating, use a while-loop so you can alter the current index and end index after each deletion.
In Java, if we remove items from a List while iterating it, it will throw java. util. ConcurrentModificationException .
the general case of iterating over an array and removing random items from the middle while continuing to iterate If you're iterating front-to-back, when you remove element N, the next element in your iteration (N+1) gets shifted down into that position. If you increment your iteration variable (as ipairs does), you'll skip that element.
In Java 8, we can use the Collection#removeIfAPI to remove items from a List while iterating it. 2.1 removeIf examples IteratorApp2A.java
So, every alternate elements got deleted. Avoiding the problem is easy. You just increment your own counter, or go reverse while iterating the array. Stay in touch!
If you're iterating front-to-back, when you remove element N, the next element in your iteration (N+1) gets shifted down into that position. If you increment your iteration variable (as ipairs does), you'll skip that element. There are two ways we can deal with this.
the general case of iterating over an array and removing random items from the middle while continuing to iterate
If you're iterating front-to-back, when you remove element N, the next element in your iteration (N+1) gets shifted down into that position. If you increment your iteration variable (as ipairs does), you'll skip that element. There are two ways we can deal with this.
Using this sample data:
input = { 'a','b','c','d','e','f','g','h','i','j','k','l','m','n','o','p' } remove = { f=true, g=true, j=true, n=true, o=true, p=true }
We can remove input
elements during iteration by:
Iterating from back to front.
for i=#input,1,-1 do if remove[input[i]] then table.remove(input, i) end end
Controlling the loop variable manually, so we can skip incrementing it when removing an element:
local i=1 while i <= #input do if remove[input[i]] then table.remove(input, i) else i = i + 1 end end
For non-array tables, you iterate using next
or pairs
(which is implemented in terms of next
) and set items you want removed to nil
.
Note that table.remove
shifts all following elements every time it's called, so performance is exponential for N removals. If you're removing a lot of elements, you should shift the items yourself as in LHF or Mitch's answer.
If you love us? You can donate to us via Paypal or buy me a coffee so we can maintain and grow! Thank you!
Donate Us With