Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Repeated test descriptions with RSpec for every user role

Creating some controller tests with RSpec, I find myself repeating several test cases for every possible user role.

For example

describe "GET 'index'" do
  context "for admin user" do
    login_user("admin")

    it "has the right title" do
      response.should have_selector("title", :content => "the title")
    end
  end

  context "for regular user" do
    login_user("user")

    it "has the right title" do
      response.should have_selector("title", :content => "the title")
    end
  end
end

This is a simple example just to make my point, but I have a lot of tests that are repeated... Of course there are also some tests that are unique for each context, but it doesn't matter here.

Is there a way to write the tests only once, and then run them in the different contexts?

like image 985
Marcos Crispino Avatar asked Jan 13 '11 15:01

Marcos Crispino


2 Answers

Shared examples are a more flexible approach to this:

shared_examples_for "titled" do
  it "has the right title" do
    response.should have_selector("title", :content => "the title")
  end
end

And in the example

describe "GET 'index'" do
  context "for admin user" do
    login_user("admin")
    it_behaves_like "titled"
  end
end

Shared examples can also be included in other spec files to reduce duplication. This works well in controller tests when checking authentication/authorization, which often makes for repetitive tests.

like image 129
zetetic Avatar answered Nov 15 '22 05:11

zetetic


describe "GET 'index'" do
  User::ROLES.each do |role|
    context "for #{role} user" do
      login_user(role)

      it "has the right title" do
        response.should have_selector("title", :content => "the title")
      end
    end
  end
end

You can use ruby's iterators in your specs. Given your particular implementation you'll have to adjust the code, but this give you the right idea for DRY'ing out your specs.

Also you'll need to make the necessary adjustments so your specs read well.

like image 31
George Anderson Avatar answered Nov 15 '22 06:11

George Anderson