Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Javascript inheritance on variable within a function (OpenERP)

Basically I'm trying to override a function by extending it. I have the following base (simplified) code:

openerp.point_of_sale = function(db) {

    var Order = Backbone.Model.extend({

        exportAsJSON: function() {
            return {'bigobject'}
        }
    })
}

Then, I'm writing my own .js where I want to inherit and override exportAsJSON function and I'm not sure how to .extend it. Here is my erroneous approach:

openerp.my_module = function(db) {

    db.point_of_sale.Order = db.point_of_sale.Order.extend({

        exportAsJSON: function() {

            var order_data = this._super();
            //... add more stuff on object
            return order_data;
        }
    })
}

What would be the correct way of doing it?

I hope I'm providing enough information for an answer (I'm working on OpenERP by the way). Any help will be appreciated.

EDIT: More specifically, the error seems to be in the extension itself:

db.point_of_sale.Order = db.point_of_sale.Order.extend({

...even if I put a simple return 0; within my exportAsJSON function, the page doesn't load and I get the following error in my browser console:

"Cannot call method 'extend' of undefined" 
like image 565
nicobustillos Avatar asked Oct 30 '12 18:10

nicobustillos


3 Answers

I think you want something like SuperClass.prototype.method.call(this):

openerp.my_module = function(db) {

    db.point_of_sale.Order = db.point_of_sale.Order.extend({

        exportAsJSON: function() {

            var order_data = db.point_of_sale.Order.prototype.exportAsJSON.call(this);
            //... add more stuff on object
            return order_data;
        }
    })
}
like image 139
Trevor Dixon Avatar answered Nov 03 '22 00:11

Trevor Dixon


This is how you would normally do that in JavaScript:

var eaj = db.point_of_sale.Order.prototype.exportAsJSON;

db.point_of_sale.Order = db.point_of_sale.Order.extend({
    exportAsJSON: function() {

        var order_data = eaj.apply( this, arguments );
        //... add more stuff on object
        return order_data;
    }
})
like image 27
freakish Avatar answered Nov 03 '22 01:11

freakish


This is basically where you problem lies:

openerp.point_of_sale = function(db) {
    var Order = Backbone.Model.extend({
     ^
     |
  this is a private variable
  not a property!

Therefore you cannot access it at all. If it was defined like this:

openerp.point_of_sale = function(db) {
    openerp.point_of_sale.Order = Backbone.Model.extend({
                           ^
                           |
                     this is now a property of point_of_sale
                     (basically public variable)

then you can access it the way you're trying to:

db.point_of_sale.Order = db.point_of_sale.Order.extend({

So, the answer is you cannot do that. You need to extend or modify db.point_of_sale instead of Order.

like image 23
slebetman Avatar answered Nov 03 '22 00:11

slebetman