Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

iOS 13 UIBarButtonItem not clickable and overlapping UINavigationBars when using UISearchController

I got a navigation bar containing some UIBarButtonItem buttons and a UISearchBar hooked up like this

var searchController: UISearchController!  override func viewDidLoad() {     super.viewDidLoad()      title = "Test"      tableView.delegate = self     tableView.dataSource = self      searchController = UISearchController(searchResultsController: nil)     navigationItem.searchController = searchController      // This leads to the bug     searchController.hidesNavigationBarDuringPresentation = false      navigationItem.leftBarButtonItem = UIBarButtonItem(barButtonSystemItem: .action, target: self, action: #selector(leftTapped))     navigationItem.rightBarButtonItem = UIBarButtonItem(barButtonSystemItem: .action, target: self, action: #selector(rightTapped)) } 

Scenario: I tap into the search bar and tap cancel afterwards.

  • Issue 1: The bar buttons are not reacting to touch except when I touch the outer most pixels of the screen (only possible with the simulator and mouse clicks).

  • Issue 2: The navigation items are overlapping when I push another view controller.

enter image description here

When I use hidesNavigationBarDuringPresentation = true it's working like expected.


The issue appears on notched and non-notched iPhones iOS 13.0 and 13.1 using Xcode 11.0 and 11.1.

Here's the whole test project: https://github.com/fl034/HidesNavigationBarDuringPresentationTest


I've filed a radar (and you should too), but maybe some of you guys have already a workaround for it?


Update 1: Bug is still there in iOS 13.1.1


Update 2: Bug is fixed in iOS 13.2 beta (thanks @Ben Gomm)

like image 385
heyfrank Avatar asked Sep 27 '19 12:09

heyfrank


2 Answers

The view debugger reveals what's going on with this bug. The contents of the navigation bar are being copied. Here's what the navigation bar looks like before you show the search:

enter image description here

And here's what it looks like afterwards:

enter image description here

The two replicant views and the extra UILabel are the problem. I don't know what they're doing there and I can't find a way to remove them.

EDIT By the way, I think some of Apple's apps display the same bug. It's easier to see if you have large titles, because then you can see the large title and the extra label at the same time:

enter image description here

like image 62
matt Avatar answered Oct 16 '22 06:10

matt


I'm now using this workaround as I want most of my users have the navigation bar visible while search is active (for several app-ux-specific reasons).

var isIosVersionWithNavigationBarBug: Bool {     if #available(iOS 13.2, *) {         return false     }     if #available(iOS 13.0, *) {         return true     }             return false } 

In my search controller I use it like this

mySearchController.hidesNavigationBarDuringPresentation = isIosVersionWithNavigationBarBug 

So if iOS 13.2 is being released and the user updates to it, the workaround is not being applied anymore.

like image 23
heyfrank Avatar answered Oct 16 '22 08:10

heyfrank