Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

How to fix issues with E402?

We are trying to fix issues with PEP8 E402.

Mostly our code is broken on:

import os
os.environ['LIB_CAN_THROW_ERROR_ON_IMPORT'] = 2
import lib
os.environ['LIB_CAN_THROW_ERROR_ON_IMPORT'] = 0 # back

-

if sys.version_info[0] > 2:
    import python3lib
else:
    import python2lib

-

try:
    import lib
except:
    print('lib is required')
    sys.exit(1)

How to solve these violations?

like image 347
aleskva Avatar asked Jan 29 '18 09:01

aleskva


1 Answers

The guidelines specified in PEP8 are just that - guidelines. They're a set of rules to follow when they make sense.

E402 refers to imports only being at the top of a file. This is to stop the following:

import pygame

# 800 lines of pygame stuff
...

import math
# 10 lines of math stuff
...

# Another 800 pygame lines

In the above example, it's very difficult to know that math is imported. If you need to use math again at the end of the file, without E402 telling you off, you'll probably import math again, which is harmless, but sloppy.

In your case, you're not being sloppy. You're specifically setting some things before importing another library, or providing better error messages to users. Simply tell your linter to ignore the warnings on those lines as suggested in the comments, with # noqa: E402 at the end of the line. You can think of this as you telling the linter "I know what I'm doing, go away."

like image 106
Adam Barnes Avatar answered Sep 20 '22 07:09

Adam Barnes