How do I merge all the cases into One?

Question

private void makeMoleVisable(int mole, PictureBox MoleHill)
    {
        switch (mole)
        {
            case 1:
                if (p01.Image == pmiss.Image && MoleHill.Image == pHill.Image)
                {
                    molesmissed ++;
                }
                p01.Image = MoleHill.Image;
              break;
            case 2:
              if (p02.Image == pmiss.Image && MoleHill.Image == pHill.Image)
              {
                  molesmissed++;
              }
                p02.Image = MoleHill.Image;
                break;

** I have 36 of these case statements each one for another for a different picture box; how do I group them all into one case statement so my code can be more efficient**

Answer 1

It looks like your case is used to select an image, then you always apply the same processing to the image.

How about storing the image in a List or Dictionary, use the mole value to retrieve the correct image, then process that image?

Something like

Dictionary<int, PictureBox> images;
var image = images[mole];
// do stuff to image

If the images are all numbered sequentially, a List is slightly more efficient. Remember that list indices are 0 based. If you number your images from 1 as seems to be the case from your switch statement (assumed in the following example), remember to adjust accordingly.

List<PictureBox> images;
int index = mole - 1; // Assumes mole starts with 1, so adjust to 0-based index
var image = images[index];