Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Getting the converter for the type

In the MSDN I've read this about EnumConverter:

You should never create an instance of an EnumConverter. Instead, call the GetConverter method of the TypeDescriptor class. For more information, see the examples in the TypeConverter base class.

Does anybody know why and is it true for my own implemented converters?

For example, I have class GradientColor and converter GradientColorConverter. Should I write

new GradientColorConverter().ConvertFrom(colorString) 

or

TypeDescriptor.GetConverter(typeof(GradientColor)).ConvertFrom(colorString);

Actually It works in both ways, but which is better?

like image 267
Andrey M. Avatar asked Sep 16 '10 04:09

Andrey M.


2 Answers

I think the latter TypeDescriptor.GetConverter(typeof(GradientColor)) because it allows other converters to add or extend the type converter system when the code is run in a different context (like custom control run in another application with its own custom typeconverters).

like image 168
yzorg Avatar answered Nov 11 '22 08:11

yzorg


The latter. If you change the type converter class you code will still work. Decoupling is good.

like image 35
Marco Avatar answered Nov 11 '22 09:11

Marco