Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Formatted print to circular buffer

I'm writing embedded code for STM32F3 mc (STM32F3-Discovery). I need to output some data to UART and I'm using DMA for this as this allows me to concentrate on sensors reading and data processing rather than on waiting for byte transmission completion. The issue however is that I have to combine:

  1. Formatted output (i.e. some from of printf)
  2. A number of consecutive prints (that occur before previous print has finished)

So I'm thinking about a circular buffer. But I don't think I know how to make sprintf to respect the end of buffer and continue writing to the beginning of the buffer. I can of course create another temporary buffer, print there, and copy byte-by-byte, but it doesn't look elegant to me.

like image 733
dccharacter Avatar asked Oct 22 '22 17:10

dccharacter


2 Answers

One solution could be to implement your own sprintf which is able to work with ring buffers. Unfortunately this won't help you out regarding a more basic problem: What would you do if your ringbuffer is full and you invoke sprintf?

If your memory situation can afford it, I'd suggest another solution for this problem:

The idea is based on two linked lists of buffers (one list for the free buffers, one list as transmit queue). The buffers are equally sized so they can store a worst case length string. The buffers build a simple heap where allocation/deallocation is only dequeuing/enqueuing an element either from the free or from the transmission list.

Having equally sized buffers guarantees you don't suffer from outer fragmentation effects like "checkerboarding" while allocating memory dynamically. Building your own heap for this job would also give you full control over the total buffer size available for transmission tasks.

I could imagine this running as follows:

  1. You allocate a buffer from the free list to render the data into.
  2. Use your render functions (suchas sprintf) to render the data in the buffer
  3. Append the data to be sent to the transmission queue (and trigger a transmission if necessary)

For the DMA transfer you handle the transfer end IRQ. There you move the buffer just transferred to the "free list" and setup the transfer for next buffer in the queue.

This solution won't be the memory efficientiest but the runtime efficiency is good as you only write to the memory once and the allocation/deallocation is only fetching/storing a pointer somewhere. Of course you'll have to make sure that you don't get race conditions between your application and the IRQ for allocation/deallocation.

Maybe this idea gives you an inspiration to solve your requirements.

like image 80
junix Avatar answered Oct 27 '22 09:10

junix


One way you could approximate it is to allocate your printf buffer as 2x the size of your ringbuffer, and then use the first half as your ring buffer. Detect an overflow, copy the overflow in the latter half back to the front (the ring portion). Something like this:

void xprintf(const char *format, ...)
{
  int written;
  va_list args;
  va_start(args, format);
  written = vsnprintf(buffer, HALF_BUFFER_SIZE, format, args);
  va_end(args);
  if (buffer + written > bufferStart + HALF_BUFFER_SIZE)
  { // time to wrap
    int overflow = (buffer + written) - (bufferStart + HALF_BUFFER_SIZE); 
    memmove(bufferStart, bufferStart + HALF_BUFFER_SIZE, overflow;
    buffer = bufferStart + overflow;
  }
}
like image 27
Travis Griggs Avatar answered Oct 27 '22 10:10

Travis Griggs