Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Efficient way to refactor a class/method/string within a directory using vim

So far, I have been manually refactoring code by using the find-and-replace operation

%s:/stringiwanttoreplace/newstring/g 

in vim.

But this is a slow and laborious process if I have stringiwanttoreplace in many files inside a specific directory.

My current/typical slow and laborious process involves a grep:-

grep -rn "stringiwanttoreplace" .

in my terminal to reveal all the locations/filenames where stringiwanttoreplace are; and now that I know which files contain stringiwanttoreplace, I will open each file one-by-one to perform the find-and-replace operation in each file.

Is there a more efficient workflow (in vim) to get this done?

CLARIFICATION: I would prefer a vim-based solution instead of a bash script/one-liner.

like image 532
Calvin Cheng Avatar asked Aug 26 '11 11:08

Calvin Cheng


3 Answers

Here's the full sequence of commands that I would use:

/stringiwanttoreplace
:vimgrep /<c-r>// **
:Qargs
:argdo %s//newstring/g
:argdo update

In the first line, we search for the target pattern. That populates the last search pattern register (:help quote/), which means that we won't have to type it out in full again.

The :vimgrep command searches the entire project for the specified pattern. Type <c-r>/ as ctlr+r followed by / - this inserts the contents of the last search pattern register onto the command line. The first and last / symbols are delimiters for the search field. The trailing ** tells Vim to look inside every file and directory below the current directory.

At this point, the quickfix list will be populated with search matches from all matching files. :Qargs is a custom command, which populates the argument list with all of the files listed in the quickfix list. Here's the implementation:

command! -nargs=0 -bar Qargs execute 'args ' . QuickfixFilenames()
function! QuickfixFilenames()
  " Building a hash ensures we get each buffer only once
  let buffer_numbers = {}
  for quickfix_item in getqflist()
    let buffer_numbers[quickfix_item['bufnr']] = bufname(quickfix_item['bufnr'])
  endfor
  return join(values(buffer_numbers))
endfunction

Add that to your vimrc file.

Having run :Qargs, our argument list should now contain all of the files that include our target string. So we can run the substitution command with :argdo, to execute the command in each file. We can leave the search field of the substitution command blank, and it will automatically use the most recent search pattern. If you want, you could include the c flag when you run the substitution command, then you'll be prompted for confirmation.

Finally, the :argdo update command saves each file that was changed.

As @Peter Rincker pointed out, you should ensure that Vim's 'hidden' option is enabled, otherwise it will raise an error when you try to switch to another buffer before writing any changes to the active buffer.

Also, note that the last 3 commands can be executed in a single command line, by separating them with a pipe character.

:Qargs | argdo %s//replacement/gc | update

The :Qargs command is pinched from this answer (by me), which in turn was inspired by this answer by DrAl. A very similar solution was posted by @ib, which suggests to me that Vim should really implement something like :quickfixdo natively.

like image 200
nelstrom Avatar answered Oct 10 '22 12:10

nelstrom


If you really want to do it in Vim you can follow the suggestions here.

like image 36
Klas Lindbäck Avatar answered Oct 10 '22 11:10

Klas Lindbäck


You can call this from within Vim (:!find ...) but you don't need to:

find . -type f | xargs sed -i 's/stringiwanttoreplace/newstring/g'

Fine-tune the file selection with the dozens of parameters described in

man find

(e.g., replace only in HTML files: -name \*.html)

This solution will try to attempt the replacement in all files. You can filter that through grep before, but that is just doing twice the work for no gain.

By the way: sed uses almost the same syntax for regular expressions as Vim (stemming from the same history).

like image 3
Boldewyn Avatar answered Oct 10 '22 12:10

Boldewyn