Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Conflicting implementations of trait in Rust

I want to implement a custom trait for &'a str and for integer numbers up to i32, but Rust does not allow me to:

use std::convert::Into;

pub trait UiId {
    fn push(&self);
}

impl<'a> UiId for &'a str {
    fn push(&self) {}
}

impl<T: Into<i32>> UiId for T {
    fn push(&self) {}
}

fn main() {}

This fails to compile with the following error:

error[E0119]: conflicting implementations of trait `UiId` for type `&str`:
  --> src/main.rs:11:1
   |
7  | impl<'a> UiId for &'a str {
   | ------------------------- first implementation here
...
11 | impl<T: Into<i32>> UiId for T {
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ conflicting implementation for `&str`
   |
   = note: upstream crates may add new impl of trait `std::convert::From<&str>` for type `i32` in future versions

&'a str does not implement Into<i32>. Is it possible to implement UiId for &'a str and everything that can be converted into i32 without specifying concrete types? How can I do that?

like image 430
Slava Baginov Avatar asked Aug 26 '16 05:08

Slava Baginov


2 Answers

The fact that &'a str does not implement Into<i32> is not taken into account, because there is no guarantee that it couldn't be added later. This would then break your code.

So if this were allowed the possible breakage would make it harder to add implementations to library traits.

Unfortunately I couldn't find documentation for that, neither in The Rust Programming Language Book nor in the Reference Manual.

The best I could find is RFC 1023, which says that a crate [...] cannot rely that Type: !Trait holds unless Type or Trait is local.

like image 158
starblue Avatar answered Oct 12 '22 13:10

starblue


I found a workaround using a marker trait. No nightly or experimental features necessary. The trick is that I define the marker trait in my crate and do not export it, so it is impossible for an upstream crate to define the marker on classes other than the ones I implement it on.

Below the marker trait is Numeric.

I use this so that I can implement Into for anything that can be converted into an f64, but also for strings in a separate impl, and other types as well.

The Numeric trait must be pub because they are warning that future versions will disallow a private Trait in a public interface.


use std::convert::Into;

pub trait Numeric {}
impl Numeric for f64 {}
impl Numeric for f32 {}
impl Numeric for i64 {}
impl Numeric for i32 {}
impl Numeric for i16 {}
impl Numeric for i8 {}
impl Numeric for isize {}
impl Numeric for u64 {}
impl Numeric for u32 {}
impl Numeric for u16 {}
impl Numeric for u8 {}
impl Numeric for usize {}


pub trait UiId {
    fn push(&self);
}

impl<'a> UiId for &'a str {
    fn push(&self) {}
}

impl<T: Into<i32> + Numeric> UiId for T {
    fn push(&self) {}
}

like image 29
Paul Chernoch Avatar answered Oct 12 '22 13:10

Paul Chernoch