Call repository and service from controller layer with Spring

Question

I use Spring Boot and Spring Data.

I have no problem in my mind to separate Repository Layer and Service Layer

So I have my UserRepository with CRUD method and some Spring Data method

• findAll
• findByUsername

I also have UserService with business method.

• checkPassword(String login,String password)
• businessMethodAction(String username)

Here is my question:

In my controller I have to call method from UserService and sometime from UserRepository. For the moment, I inject both in my controller, and I call service or repository

@Inject
UserService userService;

@Inject
UserRepository userRepository;

@RequestMapping("{username}")
private void myMethod(@PathVariable String username){
    return userRepository.findOne(username);
}

@RequestMapping("{username}/doBusineesAction")
private void myMethod(@PathVariable String username){
    return userService.doLogicalThin(username);
}

I'm just asking because I confused to inject both and to call one or the other in the same class

On another side, this would mean to duplicate method in service layer like this

public User findOne(String username){
 return userRepository.findOne(username);
}

What's your opinion?

Answer 1

Controller layer shouldn't ever call repository directly. You should always use the service layer because the service layer encapsulates your business logic surrounding that call. Just because currently there isn't any business logic, doesn't mean that you should skip the layer entirely.

Answer 2

If your controller does not require business logic or perform a single repository operation, you can use the repositories directly. Use services to implement use cases that require business logic or orchestration of repository calls.