Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

C# (If < or If >) vs Math.Sign

Might be a silly question, but is there any reason to use Math.Sign?

Is there a speed/optimization thing with using Math.Sign rather than just using an if statement? Perhaps just a best practice/code readability preference?

if (rayDirX < 0) 
    stepX = -1; 
else 
    stepX = 1;

//----------

stepX = (rayDirX < 0) ? (-1) : (1);

//----------

stepX = Math.Sign(rayDirX);
like image 630
Mythics Avatar asked Mar 12 '12 18:03

Mythics


People also ask

What is the full name of C?

In the real sense it has no meaning or full form. It was developed by Dennis Ritchie and Ken Thompson at AT&T bell Lab. First, they used to call it as B language then later they made some improvement into it and renamed it as C and its superscript as C++ which was invented by Dr.

What do you mean by C?

C is a structured, procedural programming language that has been widely used both for operating systems and applications and that has had a wide following in the academic community. Many versions of UNIX-based operating systems are written in C.

Is C language easy?

C is a general-purpose language that most programmers learn before moving on to more complex languages. From Unix and Windows to Tic Tac Toe and Photoshop, several of the most commonly used applications today have been built on C. It is easy to learn because: A simple syntax with only 32 keywords.

What is C language used for?

C programming language is a machine-independent programming language that is mainly used to create many types of applications and operating systems such as Windows, and other complicated programs such as the Oracle database, Git, Python interpreter, and games and is considered a programming foundation in the process of ...


2 Answers

I doubt there is a functional difference or much, if any, perf difference but the Math.Sign version is a little more visibly straight forward. Especially in your example where the Type of rayDirX is not declared. But it's pretty subtle and I wouldn't criticize you for using either.

EDIT:

And one other thing, your example above has a slight bug. In the case of 0 Math.Sign will return 0. Here is the decompiled code out of the framework for Math.Sign:

public static int Sign(int value)
{
  if (value < 0)
  {
    return -1;
  }
  if (value > 0)
  {
    return 1;
  }
  return 0;
}
like image 121
justin.m.chase Avatar answered Sep 25 '22 08:09

justin.m.chase


Math.Sign can be used as part of a larger expression. You could also get the sign for use in an expression via the ternary operator, but not everything thinks the ternary operator is all that readable.

like image 29
Joel Coehoorn Avatar answered Sep 22 '22 08:09

Joel Coehoorn