Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

WPF radio buttons - MVVM - binding seems to die?

I've bound the DataContext of the following Window to the code behind to give me a MVVM style to demonstrate this behaviour:

<Window x:Class="WpfApplication1.Window1"
    xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
    xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
    Title="Window1" Height="300" Width="300"
        DataContext="{Binding RelativeSource={RelativeSource Self}}">
    <StackPanel>
        <RadioButton GroupName="test" Content="Monkey" IsChecked="{Binding IsMonkey}"/>
        <RadioButton GroupName="test" Content="Turtle" IsChecked="{Binding IsTurtle}" />
    </StackPanel>
</Window>

Heres the code behind:

public partial class Window1
{
    public Window1()
    {
        InitializeComponent();
    }

    private bool _isMonkey;
    public bool IsMonkey
    {
        get { return _isMonkey; }
        set
        {
            _isMonkey = value;
        }
    }

    private bool _isTurtle;
    public bool IsTurtle
    {
        get { return _isTurtle; }
        set
        {
            _isTurtle = value;
        }
    }
}

Putting a breakpoint on the set of IsMonkey and IsTurtle and then running the application and selecting IsMonkey and IsTurtle after each other I found that it works for the first selection of each control, on the second selection the binding breaks and the breakpoints are no longer triggered?

Can anyone point me in the right direction, please?

like image 966
Andy Clarke Avatar asked Sep 20 '10 09:09

Andy Clarke


1 Answers

Your example has no Changed-notification. Your wrote it's only an example for an MVVM-style construction. Therefore I assume, you have implemented INotifyPropertyChanged or the properties are DependencyProperties. If not, the first thing you have to do is change-notification.

If you have change-notification, give the RadioButtons different group names (another name for each instance). This decouples them and the binding will not be broken anymore.

<StackPanel> 
    <RadioButton GroupName="test1" Content="Monkey" IsChecked="{Binding IsMonkey}"/> 
    <RadioButton GroupName="test2" Content="Turtle" IsChecked="{Binding IsTurtle}" /> 
</StackPanel> 

Depending on the declaration of your properties, it may also be meaningfull to declare the Binding TwoWay.

IsChecked="{Binding IsMonkey,Mode=TwoWay}

Hope this helped.

like image 101
HCL Avatar answered Oct 20 '22 19:10

HCL