would remove a key from Dictionary in foreach cause a problem? or should I better to construct a new Dictionary?

Question

for example:

1.

         foreach (var item in myDic)                 {                   if (item.value == 42)                         myDic.remove(item.key);                 } 

would the iterator works properly no matter how the statements in the inner brackets could possibly affect myDic?

2.

    var newDic = myDic.where(x=>x.value!=42).ToDictionary(x=>x.key,x=>x.value); 

Is 2nd approach a good practice? functional programming and immutable?

Answer 1

The first approach will crash at runtime, since the enumerator makes sure that nobody deletes from the underlying collection while it's enumerating.

The second approach is a nice thought, but C# dictionaries are mutable and it's neither idiomatic nor efficient to copy them around if you can accomplish the same thing with mutation.

This is a typical way:

var itemsToRemove = myDic.Where(f => f.Value == 42).ToArray(); foreach (var item in itemsToRemove)     myDic.Remove(item.Key); 

---

EDIT: In response to your question in the comments. Here's how the example in your other question works:

myList = myList.where(x=>x>10).select(x=>x-10); 

This line of code doesn't run anything; it's totally lazy. Let's say for the sake of argument that we have a foreach after it to make it look more like this question's example.

foreach (int n in myList)     Console.WriteLine(n); 

When that executes, here's what'll happen on each iteration:

1. Call MoveNext on the enumerator
2. The enumerator finds the next value greater than ten
3. Then it takes that value minus ten and sets the Current property to that
4. Binds the Current property to the variable n
5. Console.WriteLines it

You can see that there's no mystery and no infinite loop and no whatever.

Now compare to my example, supposing we left out the ToArray.

var itemsToRemove = myDic.Where(f => f.Value == 42); foreach (var item in itemsToRemove)     myDic.Remove(item.Key); 

1. Call MoveNext on the enumerator
2. The enumerator finds the next pair with value 42 and sets the Current property to that
3. Binds the Current property to the variable item
4. Removes it

This doesn't work because while it's perfectly fine to WriteLine something from a collection while you have an enumerator open on it, you aren't permitted to Remove something from a collection while you have an enumerator open on it.

If you call ToArray up front, then you start out by enumerating over the dictionary and populating the array. When we get to the foreach, the foreach statement has an enumerator open on the array, not the dictionary. You're allowed to remove from the dictionary as you iterate over the array.

Answer 2

Also you can iterate over the copy of your collection:

foreach (var item in myDic.ToList()) {     if (item.value == 42)     myDic.remove(item.key); } 

notice myDic.ToList() in foreach statement.