Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Why does short-circuiting not prevent MissingMethodException related to unreachable branch of logical AND (&&)?

While performing a check if there's a camera present and enabled on my windows mobile unit I encountered something I don't understand.

The code looks like this:

    public static bool CameraP(){

        return Microsoft.WindowsMobile.Status.SystemState.CameraPresent;
    }

    public static bool CameraE()
    {
        return Microsoft.WindowsMobile.Status.SystemState.CameraEnabled;
    }

    public static bool CameraPresent1()
    {
        return Microsoft.WindowsMobile.Status.SystemState.CameraPresent
              && Microsoft.WindowsMobile.Status.SystemState.CameraEnabled;
    }

    public static bool CameraPresent2()
    {
        return CameraP() && CameraE();
    }

When I call CameraPresent2() it return false (there is no camera present). But when I call CameraPresent1() i recieve a MissingMethodException with comment "Could not find method: get_CameraEnabled Microsoft.WindowsMobile.Status.SystemState."

Is the second term evaluated in CameraPresent1 just because they both are property (at language level)?

Is there anything else that explains the difference in behaviour?

like image 743
nj. Avatar asked Mar 08 '11 13:03

nj.


3 Answers

The second term is not evaluated.

The first term is not evaluated.

The CameraPresent1() method does not even start to execute.

When you call CameraPresent1() for the first time, the runtime must JIT-compile the MSIL into native code. This requires resolving all method calls, even ones that might be reached only conditionally. Compilation fails with the MissingMethodException.

With CameraPresent2(), the call to the getter of CameraEnabled is only compiled when CameraE() is called for the first time, which never happens.

like image 56
Ben Voigt Avatar answered Nov 10 '22 10:11

Ben Voigt


C# Specification section 7.12

The && and || operators are called the conditional logical operators. They are also called the “short-circuiting” logical operators.

The && and || operators are conditional versions of the & and | operators:

  • The operation x && y corresponds to the operation x & y, except that y is evaluated only if x is not false.

  • The operation x || y corresponds to the operation x | y, except that y is evaluated only if x is not true.


That is to say that the C# spec guarantees that CameraE() will be called if and only if CameraP() is true.

This may be an issue with aggressive compiler optimizations, and therefore the actual program seems to violate the language spec...


Edit:

Is it possible to put up a breakpoint and show the disassembly window, to see the exact code generated?

like image 43
John Gietzen Avatar answered Nov 10 '22 11:11

John Gietzen


Just a wild guess, but is it possible that this is a JIT compilation issue? When CameraPresent1 is called, is it attempting to map the call Microsoft.WindowsMobile.Status.SystemState.CameraEnabled to the underlying device? Since it cannot find the method get_CameraEnabled, the entire function fails with a MissingMethodException.

like image 5
Justin Largey Avatar answered Nov 10 '22 10:11

Justin Largey