Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Why does Format crash when anything but "%s" is used with a Variant?

I'm working with the SysUtils.Format function and variant values, and I found that this function only works if the format string is %s. I checked the documentation about the Format function but there does not exist any reference to how variant values are treated.

Consider this simple application:

{$APPTYPE CONSOLE}

uses
  Variants,
  SysUtils;

procedure TestFormat;
var
  v : Variant;
begin
  v:=100;
  writeln(Format('The VarType of v is %s',[VarTypeAsText(VarType(v))]));
  writeln(Format('The value of v is %s',[v]));//ok

  v:='100';
  writeln(Format('The VarType of v is %s',[VarTypeAsText(VarType(v))]));
  writeln(Format('The value of v is %s',[v]));//ok

  v:=100;
  writeln(Format('The VarType of v is %s',[VarTypeAsText(VarType(v))]));
  writeln(Format('The value of v is %d',[v]));//raise a EConvertError exception EConvertError: Format '%d' invalid or incompatible with argument
end;


begin
  try
     TestFormat;
  except
    on E: Exception do
      Writeln(E.ClassName, ': ', E.Message);
  end;
  readln;
end.

Is this a bug or a simple limitation of this function?

I've checked this behavior in Delphi 5, Delphi 2007 and Delphi XE.

like image 422
RRUZ Avatar asked Apr 04 '11 17:04

RRUZ


1 Answers

It is a limitation of the function. In Delphi XE, the relevant part in SysUtils starts at line 10870, which looks like this:

@CvtVariant:
        CMP     CL,'S'
        JNE     @CvtError

This is called for any variant argument. The CL register have the type required by the format string for that particular argument, for anything different than 'S', the exception is raised.

like image 144
jachguate Avatar answered Oct 06 '22 01:10

jachguate