Menu
I see in some of the code on Github
if($something_funky_happens){ throw new \LogicException(...); return; } Is this required, or it is not important to return? because I know that after you throw exceptions the script stops, so further code does not run
415
After throwing an exception, you do not need to return because throw returns for you. Throwing will bubble up the call stack to the next exception handler so returning is not required.
Yes, throwing an exception causes the method to return immediately. However, it's not a normal return. For example, there is no return value. The only way to capture control from a method that is returning as a result of an exception being thrown, is to have an exception handler.
It's not possible to both throw an exception and return a value from a single function call.
When you code using return codes, you're preparing yourself for failure, and hope your fortress of tests is secure enough. When you code using exception, you know that your code can fail, and usually put counterfire catch at chosen strategic position in your code.
I tend to denote it an error in their code. The statement is not reachable. Every static code anaylsis tool will complain about this unreachable statement. Even when it has no harm in this case you will get a load of warnings when checking your code. If you turn these warning type off you will perhaps miss other logic errors within your code. It's a real bad smell and it needs to be fixed.
124
Because they made a mistake, or it's their personal preference. It's impossible to get to the return in that code, but there's no real harm in including it.
From the docs (emphasis mine):
When an exception is thrown, code following the statement will not be executed, and PHP will attempt to find the first matching catch block.
33
If you love us? You can donate to us via Paypal or buy me a coffee so we can maintain and grow! Thank you!
Donate Us With
