Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Why can't I use the ternary ? operator to select between two function calls?

Tags:

java

I was recently programming and ran into an issue using the ? : operand. Here's my code.

    Random rand = new Random();
    for(int x = 0; x < 3; x++) {
        rand.nextInt(1) == 0 ? vertShip(board) : horizShip(board);
    }

My compiler throws me an error stating that the left hand side of the line (rand.nextInt(1) == 0 ) must be a variable. I've tried variants such as

    Random rand = new Random();
    int a = rand.nextInt(1);
    for(int x = 0; x < 3; x++) {
        a == 0 ? vertShip(board) : horizShip(board);
    }

or if statements in the left hand side but they don't fix the problem. Would anyone be able to help me?

like image 399
John Chan Avatar asked Jan 20 '13 23:01

John Chan


2 Answers

Not every expression is a statement. Use an if statement here. See Section 14.8 Expression Statements in the Java SE 7 Java Language Specification.

Certain kinds of expressions may be used as statements by following them with semicolons.

ExpressionStatement:
    StatementExpression ;

StatementExpression:
    Assignment
    PreIncrementExpression
    PreDecrementExpression
    PostIncrementExpression
    PostDecrementExpression
    MethodInvocation
    ClassInstanceCreationExpression

Examples of expression statement for each of the above:

x = y;
++x;
--x
x++;
x--;
fn(); // Or donkey.fn();, etc.
new Donkey(this);

What you can't do is:

b ? f() : g();
f() + g();

However, if you're dead set on obfuscating your code, I guess you could write:

fn(a == 0 ? vertShip(board) : horizShip(board));
(a == 0 ? vertShip(board) : horizShip(board)).fn();

(I think. I don't have a compiler to hand and wouldn't usually write such code.)

like image 156
Tom Hawtin - tackline Avatar answered Oct 10 '22 11:10

Tom Hawtin - tackline


The compiler is right. The ternary operator returns something, so you need to assign it to a variable.

like image 33
Dan D. Avatar answered Oct 10 '22 09:10

Dan D.