I decided to test one of the examples in "Effective C++" and I'm not getting the result I expected. So, apparently this (simplified) code shouldn't compile:
template <class T>
struct A {
void f(){}
};
template <class T>
struct B : public A <T> {
void f2() { f(); } // calling base function - will not compile
};
Here's the explanation (class names changed for simplicity) :
The code above won't compile, at least not with conformant compilers. Such compilers will complain that
f
doesn't exist. We can see thatf
is in the base class, but compilers won't look for it there.We need to understand why. The problem is that when compilers encounter the definition for the class template
B
, they don't know what class it inherits from. Sure, it'sA<T>
, butT
is a template parameter, one that won't be known until later (whenB
is instantiated). Without knowing whatT
is, there's no way to know what the classA<T>
looks like. In particular, there's no way to know if it has af
function.
My compiler (Visual Studio) doesn't mind... It doesn't even show any warnings.
Is the above code correct or not?
template <class T>
struct A {
void f(){}
};
template <class T>
struct B : public A <T> {
void f2() { f(); } // calling base function - will not compile
};
In the derived template, the expression f()
is not dependent on any template argument, so the compiler attempts to resolve it during the first phase lookup. At this point, the template has not yet been instantiated with the type, and the compiler won't look into the base A<T>
. The reason is that the compiler could not possibly know whether for the type of the instantiation there is a specialization of A<T>
that might not contain any members.
The solution is to make the expression dependent, the simplest way would be to qualify with this->
:
template <typename T>
void B<T>::f2() { this->f(); }
As the expression is now dependent, lookup is delayed until the second phase, where the type is substituted and A<T>
is a concrete type. Another alternative is qualifying with the class where it is defined:
template <typename T>
void B<T>::f2() { A<T>::f(); }
Again the expression becomes dependent and will be resolved during the second phase. The main difference is that in this second case, the call is qualified and thus it does not use dynamic dispatch. If A<T>::f()
was virtual it would still execute A<T>::f()
, and not the final overrider.
Is the code correct? No. Does VS accept it? Yes.
This is a known non-conformance in the Visual Studio compiler, that does not implement two phase lookup. It delays all lookup inside the template to the second phase and at that point lookup succeeds.
If you love us? You can donate to us via Paypal or buy me a coffee so we can maintain and grow! Thank you!
Donate Us With