Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Which is correct? catch (_com_error e) or catch (_com_error& e)?

Tags:

c++

exception

com

Which one should I use?

catch (_com_error e)  

or

catch (_com_error& e)
like image 668
Corey Trager Avatar asked Sep 29 '08 23:09

Corey Trager


2 Answers

The second. Here is my attempt at quoting Sutter

"Throw by value, catch by reference"

Learn to catch properly: Throw exceptions by value (not pointer) and catch them by reference (usually to const). This is the combination that meshes best with exception semantics. When rethrowing the same exception, prefer just throw; to throw e;.

Here's the full Item 73. Throw by value, catch by reference.


The reason to avoid catching exceptions by value is that it implicitly makes a copy of the exception. If the exception is of a subclass, then information about it will be lost.

try { throw MyException ("error") } 
catch (Exception e) {
    /* Implies: Exception e (MyException ("error")) */
    /* e is an instance of Exception, but not MyException */
}

Catching by reference avoids this issue by not copying the exception.

try { throw MyException ("error") } 
catch (Exception& e) {
    /* Implies: Exception &e = MyException ("error"); */
    /* e is an instance of MyException */
}
like image 73
JaredPar Avatar answered Sep 23 '22 11:09

JaredPar


Personally, I would go for the third option:

catch (const _com_error& e)
like image 36
jonner Avatar answered Sep 24 '22 11:09

jonner