Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

What is different with PushStreamContent between web api & web api 2?

I've created two identical web api projects, one in VS 2012 and another in VS 2013, both targeting the 4.5 .net framework. The projects are based on Filip W's video download tutorial found here: http://www.strathweb.com/2013/01/asynchronously-streaming-video-with-asp-net-web-api/

Copying & pasting the code from the tutorial into the VS 2012 project (using web api 1?) produces no errors (after I add the proper 'using' statements).

However, when I follow the same steps in the VS 2013 project I get the following two errors:

Error 1
The call is ambiguous between the following methods or properties: 'PushStreamContent(System.Func<Stream,HttpContent,TransportContext,Task>, MediaTypeHeaderValue)' and 'PushStreamContent(System.Action<System.IO.Stream,HttpContent,TransportContext>, MediaTypeHeaderValue)'

Error 2
'void video_stream.Controllers.VideoStream.WriteToStream(System.IO.Stream, System.Net.Http.HttpContent, System.Net.TransportContext)' has the wrong return type

So my guess is error 2 is the real problem as this code:

public async void WriteToStream(Stream outputStream, HttpContent content, TransportContext context) {...}

Is not identified as an <action> anymore between web api 1 & 2?? I'm really confused here as I'm targeting the same framework, and I can't seem to make the intuitive leap on how to fix it. My attempts at changing the WriteToStream signature have all failed.

Does anybody have a clue on what I need to get PushStreamContent to accept WriteToStream in web api 2 or VS 2013 or the new C# or where ever the difference in this code lives?

like image 238
huxley Avatar asked Nov 17 '13 13:11

huxley


1 Answers

I am not sure if this is a bug in Web API, we will investigate into it. Meanwhile you can try the following workaround:

response.Content = new PushStreamContent(async (Stream outputStream, HttpContent content, TransportContext context) =>
{
    try
    {
        var buffer = new byte[65536];

        using (var video = File.Open(filename, FileMode.Open, FileAccess.Read))
        {
            var length = (int)video.Length;
            var bytesRead = 1;

            while (length > 0 && bytesRead > 0)
            {
                bytesRead = video.Read(buffer, 0, Math.Min(length, buffer.Length));
                await outputStream.WriteAsync(buffer, 0, bytesRead);
                length -= bytesRead;
            }
        }
    }
    finally
    {
        outputStream.Close();
    }
});

Note: I made another change(removed the catch block) to the code to allow exceptions to propagate. This is so that your clients know that some error happened at the service otherwise they would assume everything went smooth.

like image 173
Kiran Avatar answered Oct 22 '22 02:10

Kiran