When using Bitbucket for source control, there's an "Approve" button that appears at the upper right of the commit page:
It appears to generate an activity message in the repositories overview page:
Is that all it does? What is the intended purpose of that button? Is it just a social feature?
To review a pull request, select either Approve or Needs work within the header of a pull request. Click the button again or click a different one to change your status. Approving a pull request lets the author know you reviewed their changes and that you feel the work can be merged with the target branch.
Ideally, a Changes Requested status will be accompanied by comments and tasks to clarify what the author can do to get the pull request approved. A Changes Requested status will also block merges when configured to do so.
After your review, if the pull request is ready to be merged (or if you trust the author to resolve your tasks before merging), click the Approve button in the top right. A green checkmark appears next to your name in the Reviewers field after you approve a pull request.
To add default reviewers for pull requests (requires project admin permissions): Go to Project settings > Default reviewers. Click Add default reviewers. For the Source branch and Target branch fields, select either Branch name, Branch pattern, Branching model, or Any branch.
One use case is when a pull request gets a certain number of approvals, then it gets merged, either automatically or manually.
Thus it becomes easy to filter all the pull requests which are ready to be merged.
It's quite a common feature in code review tools. I have found it to be almost identical in GitLab
too.
If you love us? You can donate to us via Paypal or buy me a coffee so we can maintain and grow! Thank you!
Donate Us With