VSCode Integrated Terminal creates a separate window

Question

Just installed VSCode and git bash.

I've added the following lines to the settings.json file:

{
    "terminal.integrated.shell.windows": "D:\\Program Files\\Git\\git-bash.exe" 
}

When I press Ctr+` to open the integrated shell window, instead of opening inside the main editor at the bottom it opens a new window:

Why isn't it showing in the usual place?

Answer 1

According to this vscoode GitHub Issue (#7286):

... git-bash.exe is a Windows application (with WinMain as entry), but bash.exe is a console application (with main as entry). To be used as integrated shell, the executable must be a console application, so that stdin/stdout/stderr can be redirected.

The recommended approach is to use:

"terminal.integrated.shell.windows": "C:\\Program Files\\Git\\bin\\bash.exe"