Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Using number pipe throws InvalidPipeArgumentException (Invalid argument '1' for pipe 'DecimalPipe')

I want to write some number into <input> and dynamically display it as a decimal inside {{}} through pipe. It throws exception instead. Here's my code:

app.template.html:

<h1>amount = {{amount|number:'1.2-2'}}</h1>
<input [(ngModel)]="amount"/>

app.component.ts:

import {Component} from '@angular/core';
@Component({
  selector: 'my-app',
  templateUrl: 'app/app.template.html'
})
export class AppComponent {
  private amount:number;
}

Plunker: http://plnkr.co/edit/I7ynnwBX4DWJfHNPIPRu?p=preview

Write any number into the input and see exception being thrown in the console.


Edit:

Working code as per rinukkusu suggestion:

app.template.html:

<h1>amount = {{amount|number:'1.2-2'}}</h1>
<input [ngModel]="amount" (ngModelChange)="onChange($event)"/>

app.component.ts:

import { Component } from '@angular/core';
@Component({
  selector: 'my-app',
  templateUrl: 'app/app.template.html'
})
export class AppComponent {
  private amount:number;

  onChange($event) {
    this.amount = +$event;
  }
}

This + next to $event is very important and what makes conversion from string to number possible!

like image 704
Celebes Avatar asked Jul 19 '16 14:07

Celebes


1 Answers

Looking at the source code of Angular 2 I found this:

if (!isNumber(value)) {
  throw new InvalidPipeArgumentException(pipe, value);
}

which means, you actually need to pass a variable of type number. Using the input and binding to ngModel like you did there, your amount variable will always be of type string.

Remember: type hints are only visible in TypeScript. After transpiling to JavaScript you lose that information

I'd suggest implementing a new pipe which converts your variable to a number on the fly:

@Pipe({
    name: 'toNumber'
})
export class ToNumberPipe implements PipeTransform {
    transform(value: string):any {
        let retNumber = Number(value);
        return isNaN(retNumber) ? 0 : retNumber;
    }
}

You can use it like this:

<h1>amount = {{amount | toNumber | number:'1.2-2'}}</h1>
<input [(ngModel)]="amount" />
like image 144
rinukkusu Avatar answered Nov 04 '22 03:11

rinukkusu