Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Unit testing custom model binder in ASP.NET MVC 2

I've wrote custom model binder in project, that uses ASP.NET MVC 2. This model binder bind just 2 fields of model:

public class TaskFormBinder : DefaultModelBinder
{
    protected override void BindProperty(ControllerContext controllerContext,
        ModelBindingContext bindingContext,
        PropertyDescriptor propertyDescriptor)
    {           
        if (propertyDescriptor.Name == "Type")
        {
            var value = bindingContext.ValueProvider.GetValue("Type");
            var typeId = value.ConvertTo(typeof(int));
            TaskType foundedType;
            using (var nhSession = Domain.GetSession())
            {
                foundedType = nhSession.Get<TaskType>(typeId);
            }
            if (foundedType != null)
            {
                SetProperty(controllerContext, bindingContext, propertyDescriptor, foundedType);
            }
            else
            {
                AddModelBindError(bindingContext, propertyDescriptor);
            }
            return;
        }
        if (propertyDescriptor.Name == "Priority")
        { /* Other field binding ... */
            return;
        }
        base.BindProperty(controllerContext, bindingContext, propertyDescriptor);
    }
}

How can i test this model binder using standart VS unit testing? Spent some hours googling, find couple examples (http://www.hanselman.com/blog/SplittingDateTimeUnitTestingASPNETMVCCustomModelBinders.aspx), but this examples is for MVC1, and dont work when using MVC2.

I appreciate your help.

like image 421
Mike G. Avatar asked Jan 02 '10 19:01

Mike G.


2 Answers

I've modified Hanselman's MVC 1 example to test ASP.Net MVC 2 model binders...

[Test]
public void Date_Can_Be_Pulled_Via_Provided_Month_Day_Year()
{
    // Arrange
    var formCollection = new NameValueCollection { 
        { "foo.month", "2" },
        { "foo.day", "12" },
        { "foo.year", "1964" }
    };

    var valueProvider = new NameValueCollectionValueProvider(formCollection, null);
    var modelMetadata = ModelMetadataProviders.Current.GetMetadataForType(null, typeof(FwpUser));

    var bindingContext = new ModelBindingContext
    {
        ModelName = "foo",
        ValueProvider = valueProvider,
        ModelMetadata = modelMetadata
    };

    DateAndTimeModelBinder b = new DateAndTimeModelBinder { Month = "month", Day = "day", Year = "year" };
    ControllerContext controllerContext = new ControllerContext();

    // Act
    DateTime result = (DateTime)b.BindModel(controllerContext, bindingContext);

    // Assert
    Assert.AreEqual(DateTime.Parse("1964-02-12 12:00:00 am"), result);
}
like image 117
Russell Giddings Avatar answered Jan 17 '23 05:01

Russell Giddings


The general approach is to create a mock ControllerContext, mock ModelBindingContext, and mock PropertyDescriptor, and then call the method.

If your model binder uses other services, which it looks like yours does (you're using NHibernate?), then you'll have to abstract those out and provide mocks of them as well.

The unit test code will look something like this:

// Arrange
ControllerContext mockControllerContext = ...;
ModelBindingContext mockModelBindingContext = ...;
PropertyDescriptor mockPropertyDescriptor = ...;
SomeService mockService = ...;

TaskFormBinder taskFormBinder = new TaskFormBinder();
taskFormBinder.Service = mockService;

// Act
taskFormBinder.BindProperty(
    mockControllerContext, mockModelBindingContext, mockPropertyDescriptor);

// Assert
// ... here you need to inspect the values in the model binding context to see that it set the right properties

What problem(s) are you having writing the unit test?

like image 23
Eilon Avatar answered Jan 17 '23 04:01

Eilon