Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

UIRefreshControl freezes when temporarily showing other tab (iOS 7)

I have the following on one of my tabs:

- (void)viewDidLoad
{
    [super viewDidLoad];

    self.clearsSelectionOnViewWillAppear = YES;

    UIRefreshControl* refreshControl = [[UIRefreshControl alloc] init];
    refreshControl.attributedTitle   = [[NSAttributedString alloc] initWithString:@"Sync"];
    [refreshControl addTarget:self 
                       action:@selector(refresh:) 
             forControlEvents:UIControlEventValueChanged];
    self.refreshControl = refreshControl;

    //### Workaround: http://stackoverflow.com/a/19126113/1971013
    dispatch_async(dispatch_get_main_queue(), ^
    {
        [self.refreshControl beginRefreshing];
        [self.refreshControl endRefreshing];
    });
}

- (void)refresh:(id)sender
{
    if ([Settings sharedSettings].haveAccount == YES)
    {
        [[DataManager sharedManager] synchronizeWithServer:^(NSError* error)
        {
            [sender endRefreshing];
        }];
    }
    else
    {
        [sender endRefreshing];
    }
}

Refresh control starts spinning normally when pulling down table.

However, when I, while it spins, shown an other tab shortly and then go back, the refresh control stops spinning.

Any idea why?

like image 873
meaning-matters Avatar asked Mar 24 '14 23:03

meaning-matters


2 Answers

Try moving this piece of code from viewDidLoad to viewWillAppear:

//### Workaround: http://stackoverflow.com/a/19126113/1971013
dispatch_async(dispatch_get_main_queue(), ^
{
    [self.refreshControl beginRefreshing];
    [self.refreshControl endRefreshing];
});
like image 153
NeverHopeless Avatar answered Nov 22 '22 08:11

NeverHopeless


The more sensible approach to fix this issue would be to end / begin refreshing on viewWillDisappear / viewWillAppear respectively

override func viewWillDisappear(_ animated: Bool) {
    super.viewWillDisappear(animated)
    refreshControl.endRefreshing()
}

override func viewWillAppear(_ animated: Bool) {

    super.viewWillAppear(animated)

    if isLoadingData {
        // for simplicity using harcoded height for refresh control
        tableView.setContentOffset(CGPoint(x: 0, y: -60), animated: false)
        refreshControl.beginRefreshing()
    }
}
like image 32
vasantpatel Avatar answered Nov 22 '22 07:11

vasantpatel