<tr> onClick not working

Question

I want to turn my table rows into links using JS. I have it looking like this:

<tr onClick='javascript:window.location.href='url';'>

However, when I try to click, it doesn't go the page as I want. In fact, clicking seems to have no action.

Any help?

Edit:

As for the quotes, I forgot to mention that I'm echoing this with PHP. Here's my updated code:

echo "<tr onClick='window.location.href='url?id=" . $var . "';'></tr>";

Should I be doing some sort of escaping like /" in this case?

Answer 1

First of all, no javascript: in event handlers - they contain JavaScript code, not an URL. It just works because javascript: is a label in this case and thus not a syntax error. Besides that, any editor with proper syntax highlighting would have shown you that you are breaking the quoting as you are using single quotes for the HTML attribute and inside the attribute.

Here's the fixed code:

<tr onclick="window.location.href = 'url';">

Besides that, inline event handlers are dirty. Better attach them nicely using jQuery:

$('tr').click(function() {
    location.href = 'url';
});