token is not being generated after upgrading to firebase messaging 17.1.0

Question

I noticed the in com.google.firebase:firebase-messaging:17.1.0 FirebaseInstanceIdService has been deprecated so tried overriding onNewToken() in FirebaseMessagingService but it seems like it never gets called.

and FirebaseInstanceId.getInstance().getInstanceId().getResult().getToken() return an exception

java.lang.IllegalStateException: Task is not yet complete` 

is there anything in particular that I'm missing?

So I have followed the docs and here is my code

Manifest:

<!--<service android:name=".network.AppFirebaseInstanceIdService">-->
    <!--<intent-filter>-->
    <!--<action android:name="com.google.firebase.INSTANCE_ID_EVENT" />-->
    <!--</intent-filter>-->
    <!--</service>-->
    <service
        android:name=".network.AppFirebaseMessagingService"
        android:stopWithTask="false">
        <intent-filter>
            <action android:name="com.google.firebase.MESSAGING_EVENT" />
        </intent-filter>
    </service>

AppFirebaseMessagingService:

 @Override
    public void onNewToken(String s) {
        Log.d(TAG,"Refreshed token: " + s);
        sendRegistrationToServer(s);
    }

In Activity:

    _btnTemptest.setOnClickListener(new View.OnClickListener() {
     @Override
     public void onClick(View v) {

      FirebaseMessaging.getInstance().setAutoInitEnabled(true);

      Toast.makeText(LoginActivity.this, FirebaseInstanceId.getInstance().getInstanceId().getResult().getToken(), Toast.LENGTH_SHORT).show();
      // which throws java.lang.IllegalStateException: Task is not yet complete` 

     }
    });

Answer 1

is there anything in particular that I'm missing?

No you are not missing anything

Suggestion

Don't Use FirebaseInstanceId.getInstance().getInstanceId().getResult().getToken() sometime it throw an exception( i have also face the same issue)

how to get Token

You need to Use

FirebaseInstanceId.getInstance().getInstanceId().addOnSuccessListener( MyActivity.this,  new OnSuccessListener<InstanceIdResult>() {
     @Override
     public void onSuccess(InstanceIdResult instanceIdResult) {
           String newToken = instanceIdResult.getToken();
           Toast.makeText(LoginActivity.this, newToken, Toast.LENGTH_SHORT).show();

     }
 });

For more information check it here firebase github link