Testing component throws Expression has changed after it was checked, when I try to change value

Question

I am using test host component to control values passed into the component I am trying to test:

@Component({
  selector: `host-component`,
  template: `<edit-text [definition]="definition" [formGroup]="formGroup"></edit-text>`
})
class TestHostComponent {
  formGroup = new FormGroup({
    text: new FormControl('')
  })

  definition: any = {
    name: 'text',
    title: 'Text Field',
    required: false
  }

  @ViewChild(EditTextComponent) component: EditTextComponent
}

Now I would like to test a toggle of required:

  it('should indicate required', () => {
    hostComponent.definition.required = true
    fixture.detectChanges()
    ...
  })

However when I do this I get:

Error: ExpressionChangedAfterItHasBeenCheckedError: Expression has changed after it was checked. Previous value for 'ng-valid': 'true'. Current value: 'false'.

The component I am testing is fairly simple:

@Component({
  selector: 'edit-text',
  templateUrl: './edit-text.component.html',
  styleUrls: ['./edit-text.component.scss']
})
export class EditTextComponent {
  @Input() formGroup: FormGroup
  @Input() definition: any
}

Template:

<div [formGroup]="formGroup">
  <mat-form-field appearance="fill">
    <mat-label>Text</mat-label>
    <input matInput formControlName="{{definition.name}}" [required]="definition.required">
    <mat-error *ngIf="formGroup.get(definition.name).hasError('required')">You must enter a value</mat-error>
  </mat-form-field>
</div>

Can I update the values in the parent (TestHostComponent) to have the component I am trying to test pick up the changes?

Answer 1

Looks like this might be my problem:

https://github.com/angular/angular/issues/23657

I can update my TestHostComponent:

@Component({
  selector: `host-component`,
  template: `<edit-text [definition]="definition" [formGroup]="formGroup"></edit-text>`,
  changeDetection: ChangeDetectionStrategy.OnPush
})

Seems to do the trick, and I don't update required dynamically in the parent component anywhere other than testing. Still stinks that this is still a known issue with Angular and reactive forms.