T-SQL How to end an IF-ELSE IF-ELSE block

Question

When I run the below procedure with the correct parameters so that the -1 value isn't returned, none of my DML statements are firing. I'm guessing that it's treating all my DML statements as part of the ELSE block.

SQL Server 2014

How do I end an IF-ELSE-ELSE-IF block?

ALTER PROCEDURE [GenerateNumber] (     @Code VARCHAR(2) ) AS BEGIN     DECLARE @stringConcat VARCHAR = 'X';      IF @Code = 'KP'         SET @stringConcat += 'Y';     ELSE IF @Code = 'RL'         SET @stringConcat += 'Z';     ElSE         -- Return error code and stop processing         SELECT -1;         RETURN;      BEGIN TRY         -- Various DML statements...          SELECT @successValue;         RETURN;     END TRY     BEGIN CATCH         SELECT -1;         RETURN;     END CATCH END 

Answer 1

Okay you have to use Begin and End in the Else statement as it contains multiple lines of code.

    IF @Code = 'KP'         SET @stringConcat += 'Y';     ELSE IF @Code = 'RL'         SET @stringConcat += 'Z';     ElSE     Begin         -- Return error code and stop processing         SELECT -1;         RETURN;     End 

Answer 2

Your indenting is lying to you.

IF @Code = 'KP'      SET @stringConcat += 'Y';  ELSE IF @Code = 'RL'      SET @stringConcat += 'Z';  ElSE      -- Return error code and stop processing      SELECT -1;  -- THIS is evaluated as the ELSE      RETURN;     -- THIS is run regardless. 

Only the 1st line after that last ELSE will be executed as an ELSE condidion. That RETURN will be run regardless. Your BEGIN TRY can't be reached.

Try this:

IF @Code = 'KP'      SET @stringConcat += 'Y';  ELSE IF @Code = 'RL'      SET @stringConcat += 'Z';  ElSE      BEGIN      -- Return error code and stop processing      SELECT -1;      RETURN;      END