So i have this error:
Error 3 error C2143: syntax error : missing ';' before 'type' g:\lel\tommy\tommy\tommy.c 34 tommy
from this block of code:
#include <stdio.h>
#include <stdlib.h>
#include <time.h>
#include <malloc.h>
#include <conio.h>
struct matrep {
unsigned rows,cols;
double *matrix;
};
int matrix_read(struct matrep *mat, const char *filename)
{
FILE *fptr;
unsigned m, n;
if ((fptr = fopen(filename, "r")) == NULL)
{
fprintf(stderr, "Cannot Open File %s\n", "matrixA.txt");
return -1;
}
if (fscanf(fptr, "\n\nnrows %u, columns %u\n\n", &m, &n) != 2)
{
fprintf(stderr, "Failed to read dimensions\n");
return -1;
}
mat->matrix = (double *)malloc(sizeof(double) * m * n);
if (mat->matrix == 0)
{
fprintf(stderr, "Failed to allocate %d*%d matrix\n", m, n);
return -1;
}
double *ptr = mat->matrix;//this is where it says that the error occured.
for (int i = 0; i < m; i++)
{
for (int j = 0; j < n; j++)
{
double x;
if (fscanf(fptr, " %5.2lf", &x) != 1)
{
fprintf(stderr, "Failed to read element matrix[%d,%d]\n", i, j);
free(mat->matrix);
mat->matrix = 0;
mat->columns = 0;
mat->rows = 0;
return -1;
}
*ptr++ = x;
}
}
fclose(fptr);
mat->columns = m;
mat->rows = n;
return 0; // Success
}
int main(int argc, _TCHAR* argv[])
{
return 0;
}
I have no idea what that means, or where I'm making the mistake. Please help.
UPDATE:
While the original question was solved, i have received the exact same error, but in another block of code, and I'm writing as per recommended by the chosen answer:
int matrix_multiplication(struct matrep *mat_left,struct matrep *mat_right,struct matrep *result)
{
if(mat_left->cols != mat_right->rows)
{
fprintf(stderr, "The number of columns from the left matrix are different from the number of colums from the right matrix");
return -1;
}
double *p = NULL;//this is where the same error occurs the first time
double *pa = NULL;
int i,j;
result->rows = mat_left->rows;
result->cols = mat_right->cols;
p = result->matrix;
for (pa = mat_left->matrix, i = 0; i < mat_left->rows; i++, pa += mat_left->cols)
for (j = 0; j < b->w; j++)
*p++ = dot(pa, mat_right->matrix + j, mat_left->cols, mat_right->cols);
return 0;
}
I'm really lost here, I am reading this code and have no idea why it gives me the same error.
When compiling a C program, MSVC doesn't allow declarations to follow statements in a block (it uses old C90 rules - support for declarations mixed with statements was added to C in the 1999 standard).
Move the declaration of double *ptr
to the top of matrix_read()
:
int matrix_read(struct matrep *mat, const char *filename)
{
FILE *fptr;
unsigned m, n;
double *ptr = NULL;
// ...
ptr = mat->matrix; //this is where the error used to occur
// ...
}
I really wish MS would implement this 'extension' to their C compiler.
Are you compiling with c99 or c89?
The error appears to be because you are defining a variable within the body of the function (allowed in c99 not c89). Move double *ptr
to the beginning of the function and then just assign ptr = mat->matrix;
where the error now is.
If you love us? You can donate to us via Paypal or buy me a coffee so we can maintain and grow! Thank you!
Donate Us With