I'm using java config with @ComponentScan
in order to initialize my beans and @EnableAspectJAutoProxy(proxyTargetClass=true)
to use cglib proxies.
In this project we have a lots of generated services autowired between them using @Autowired
. It works pretty well.
But, for some of these services I've added @Async
(I've also added @EnableAsync(proxyTargetClass = true)
on my @Configuration
class).
After that, I'm getting:
Caused by: org.springframework.beans.factory.BeanCurrentlyInCreationException: Error creating bean with name 'ConversationUserLocalService': Bean with name 'ConversationUserLocalService' has been injected into other beans [ConversationUserHistoryLocalService] i n its raw version as part of a circular reference, but has eventually been wrapped. This means that said other beans do not use the final version of the bean. This is often the result of over-eager type matching - consider using 'getBeanNamesOfType' with the 'a llowEagerInit' flag turned off, for example.
I guess this is because Spring is injecting the service with @Async
method BEFORE AOP creates the proxy. Could this be the problem? How I should fix it?
In order to try to clarify my problem, let's say I have:
@Service A, B & C;
A has autowired B & C, B has autowired A & C, C has autowired A & B;
C has a method marked as @Async.
When Spring initialize applicationContext, it tries to initialize A, but needs B & C, so it initializes them. But after all, AOP tries to make a proxy of C (because @Async) and then it detects that autowired C into B and A is not the same as proxy of C so it fails.
I hope this can explain a little more what is happening.
But with a circular dependency, Spring cannot decide which of the beans should be created first since they depend on one another. In these cases, Spring will raise a BeanCurrentlyInCreationException while loading context. It can happen in Spring when using constructor injection.
To resolve circular dependencies: Then there are three strategies you can use: Look for small pieces of code that can be moved from one project to the other. Look for code that both libraries depend on and move that code into a new shared library. Combine projectA and projectB into one library.
Avoiding circular dependencies by refactoring Circular dependencies create tight couplings between the classes or modules involved, which means both classes or modules have to be recompiled every time either of them is changed.
To remove the cycle using DI, we remove one direction of the two dependencies and harden the other one. To do that we should use an abstraction: in the order module, we add the DiscountCalculator interface. Thus, the Order class depends on this new type and the order module no longer depends on the customer module.
Finally I sorted it out using @Lazy
on services (with methods annotated with @Async
), and also, where they were autowired. This way I guess Spring only initialize and autowires those services when they're required instead of on application context initialization.
I have same issue and I solved this issue:
I identified which @Autowired
property is reason for circular dependency.
Eg:
@Autowired private TestService testService;
(Tips to identified just try to comment and find out which property is reason to break the application)
Once identified just use @Lazy
on top of this @Autowired
variable.
Eg :
@Lazy @Autowired private TestService testService;
And Application worked smoothly.
If you love us? You can donate to us via Paypal or buy me a coffee so we can maintain and grow! Thank you!
Donate Us With