Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Should I Stop Stopwatch at the end of the method?

Tags:

c#

.net

stopwatch

Let's imagine we have simple measurements using Stopwatch

public void DoWork() {     var timer = Stopwatch.StartNew();     // some hard work     Logger.Log("Time elapsed: {0}", timer.Elapsed);     timer.Stop(); // Do I need to call this? } 

According to MSDN:

In a typical Stopwatch scenario, you call the Start method, then eventually call the Stop method, and then you check elapsed time using the Elapsed property.

I'm not sure if I should call this method when I'm no longer interested with timer instance. Should I "clear up" using Stop method?

EDIT

Keep in mind that Logger.Log(..) costs nothing because timer.Elapsed is read before the logger logs.

like image 716
Dariusz Avatar asked Jun 10 '14 11:06

Dariusz


2 Answers

No, you don't need to stop it. Stop() just stops tracking elapsed time. It does not free up any resources.

like image 124
Uriil Avatar answered Sep 24 '22 23:09

Uriil


No, there is no need to stop or clean it up.

Stopwatch does not use any unmanaged resources (if you thought of IDisposable). It actually does not use any resources at all (except the memory used by the object itself, of course)! It also does not consume any CPU while measuring the elapsed time!

In windows implementations of .NET (full .NET Framework, Mono, .NET Core), it just calls the QueryPerformanceCounter() Windows API when needed (on Start() and Stop() and when reading Elapsed) to retrieve a high resolution time stamp.

In Linux implementations of Mono and .NET Core, it uses clock_gettime function to retrieve a monotonic increasing time value.

To anyone with a real curiosity about the implementation details: read this post.

like image 37
Mohammad Dehghan Avatar answered Sep 22 '22 23:09

Mohammad Dehghan