Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Servlet filter wrapper - trouble changing content type

I have RESTful web service which is consumed by javascript. This service returns a content type of "application/json". However, for IE the content type must be "text/html". So I written a filter and wrapper to change the content type when IE is detected as the client. My logic seems to have no effect on the content type. What am I doing wrong?

The filter:

public class IE8Filter implements Filter {

    private Logger logger = LoggerHelper.getLogger();

    @Override
    public void destroy() {}

    @Override
    public void doFilter(ServletRequest req, ServletResponse res,
            FilterChain chain) throws IOException, ServletException {

         HttpServletRequest request = (HttpServletRequest) req;
         HttpServletResponse response = (HttpServletResponse) res;

         String userAgent = request.getHeader("User-Agent");
         logger.debugf("User Agent  = '%s'", userAgent);

         IE8FilterResponseWrapper wrapper = new IE8FilterResponseWrapper(response);



         chain.doFilter(req, wrapper);


         if (userAgent.contains("MSIE 8") || userAgent.contains("MSIE 7")) {

             wrapper.setContentType("text/html");
             logger.debugf("Content Type  = '%s'", wrapper.getContentType());
         }


    }

    @Override
    public void init(FilterConfig arg0) throws ServletException {}

}

The wrapper:

public class IE8FilterResponseWrapper extends HttpServletResponseWrapper {


    private String contentType;

    public IE8FilterResponseWrapper(HttpServletResponse response) {
        super(response);
    }

    public void setContentType(String type) { 
        this.contentType = type;
        super.setContentType(type); 
    } 

     public String getContentType() { 
         return contentType; 
     } 
}
like image 679
badgerduke Avatar asked Oct 01 '22 20:10

badgerduke


1 Answers

I found an answer. The trick was to prevent my web service from setting the content-type using my wrapper:

public class IE8FilterResponseWrapper extends HttpServletResponseWrapper {


    public IE8FilterResponseWrapper(HttpServletResponse response) {
        super(response);
    }

    public void forceContentType(String type) {
        super.setContentType(type); 
    }

    public void setContentType(String type) { 

    } 

    public void setHeader(String name, String value) {

        if (!name.equals("Content-Type")) {
            super.setHeader(name, value);
        }
    }

    public void addHeader(String name, String value) {
        if (!name.equals("Content-Type")) {
            super.addHeader(name, value);
        }

    }

     public String getContentType() { 
         return super.getContentType(); 
     } 
}

And my filter now looks like:

public class IE8Filter implements Filter {

    private Logger logger = LoggerHelper.getLogger();

    @Override
    public void destroy() {}

    @Override
    public void doFilter(ServletRequest req, ServletResponse res,
            FilterChain chain) throws IOException, ServletException {

         HttpServletRequest request = (HttpServletRequest) req;
         HttpServletResponse response = (HttpServletResponse) res;

         String userAgent = request.getHeader("User-Agent");
         logger.debugf("User Agent  = '%s'", userAgent);

         IE8FilterResponseWrapper wrapper = new IE8FilterResponseWrapper(response);

         if (userAgent.contains("MSIE 8") || userAgent.contains("MSIE 7")) {

             wrapper.forceContentType("text/html");
             chain.doFilter(req, wrapper);

         }
         else {
             chain.doFilter(req, res);
         }


    }

    @Override
    public void init(FilterConfig arg0) throws ServletException {}

}

I'm not sure if this was how wrappers were intended to be used but heck it works.

like image 79
badgerduke Avatar answered Oct 05 '22 12:10

badgerduke