Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Questionnaire/Checklist for Bitbucket Pullrequest reviewers

I am trying to see if I can enforce a questionnaire in Bitbucket before reviewers approve a Pull-request. Sample questions that I would like to use are..

  1. If the changes made are to a global repository shared among many regions, did you check with the reviewers if he/she informed the global team or any particular individuals?
  2. Did you check variable naming conventions?
  3. Are there enough comments around any complex logic?
  4. Are there enough unit tests around the new logic and where it is relevant, did you check the code coverage report?

These are just some sample questions and some of them of course can be monitored using various plugins during the build process or in Sonar etc, but there are always things where we have no immediate way of automating, like the first sample question above. So, until they can be automated, I at least want to make sure those questions are addressed before a pull-request is approved.

Question: Has anybody thought of a similar situation and found any support directly with in Bitbucket or using any plugins? My quick google search didn't yield any useful results

like image 703
endless Avatar asked Jul 17 '16 14:07

endless


People also ask

How do I review and approve pull request in Bitbucket?

To review a pull request, select either Approve or Needs work within the header of a pull request. Click the button again or click a different one to change your status. Approving a pull request lets the author know you reviewed their changes and that you feel the work can be merged with the target branch.


1 Answers

If you're looking for a way to have simple custom check lists (tasks) in your pull-requests, this appears to be a feature in the Premium version of Bitbucket as discussed in this bitbucket blog post, you can create tasks from comments (any version of bitbucket):

click Create task from a comment

However, you'll need the 'Premium' plan if you want to be able to "Require pull request task completion.".

Using the dedfault tasks for bitbucket app, you can setup default tasks on a per-repository basis. e.g. if you have a repository which is heavy on schema changes, you may wish to always include a task of "Have you checked with DBA team if this schema affects downstream processes", or "Does the code conform to company coding standards and conventions".

like image 157
alexkb Avatar answered Oct 15 '22 11:10

alexkb