Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Python, doing conditional imports the right way

Right now I have a class called A.

I have some code like this..

from my.package.location.A import A

...


foo = A.doSomething(bar)

This is great.

But now I have a new version of A called A, but in a different package, but I only want to use this other A in a certain scenario. So I can do something like this:

if(OldVersion):
    from my.package.location.A import A
else:
    from new.package.location.A import A

...

foo = A.doSomething(bar)

This works fine. But it is ugly. How can I do this better? I really want to do something like this

from my.abstraction.layer.AFactory import AFactory
...
myA = AFactory.giveMeA() # this looks at "OldVersion" and gives me the correct A
foo = myA.doSomething(bar)

is there a way I can do that easier? Without the factory layer? This now can turn every static method call on my class into 2 lines. I can always hold a reference in a class to reduce the impact, but im really hoping python has a simpler solution.

like image 949
asdasdasd Avatar asked Jul 22 '11 17:07

asdasdasd


3 Answers

Put your lines into a_finder.py:

if OldVersion:
    from my.package.location.A import A
else:
    from new.package.location.A import A

Then in your product code:

from a_finder import A

and you will get the proper A.

like image 62
Ned Batchelder Avatar answered Oct 30 '22 05:10

Ned Batchelder


You could do something like this:

AlwaysRightA.py

import sys
if(OldVersion):
    from my.package.location.A import A
else:
    from new.package.location.A import A
sys.modules[__name__] = A

Then simply import AlwaysRightA as A and you're set.

like image 26
Chris Eberle Avatar answered Oct 30 '22 04:10

Chris Eberle


Could you just make a package in some third location that checks OldVersion and gets it's own A from the right place, then always import that package?

like image 1
psr Avatar answered Oct 30 '22 05:10

psr