Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Prevent commit before peer review in svn

Tags:

svn

hook

Is there any svn hook for peer review? I would like to make sure that any developer could not commit code until it gets reviewed by a peer. How can this be enforced by svn?

like image 616
Mohit Jain Avatar asked Jan 18 '12 06:01

Mohit Jain


1 Answers

I sense a misunderstanding here: If you are trying to add code review as a pre-check-in step, you are treating your source repository as the authority for perfect, ideal code, but keep imperfect code out of it. This is detrimental to the overall usefulness of a source repository. Code should be in the repository as early as practically possible. Code in the repository is change-tracked, easily accessible, easier to review and easier to backup.

So, go the easy route: Store code in branches (maybe an extra unreviewed folder alongside branches and tags) and review the branch before it gets merged into its target branch. The technical side gets easier, and you have no need for pre-commit hooks.

like image 113
thiton Avatar answered Oct 21 '22 14:10

thiton