Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Node, Express - CANNOT GET route

I am building an Express app and having some issues with routing. My '/' route is working perfectly, however other routes are not. I've looked into other questions people have posted and these have not resolved my issues.

I have a routes/index.js file:

module.exports = function(app){
  app.use('/', require('./routes/home'));
  app.use('/about', require('./routes/about'));
}

My routes/home.js: - WORKING!

const express = require('express');
const router = express.Router();

router.get('/', function(req, res) {
   res.render('app/home');
});

module.exports = router;

My routes/about.js: - NOT WORKING!

const express = require('express');
const router = express.Router();

router.get('/about', function(req, res) {
   res.render('app/about');
});

module.exports = router;

When I go to '/about' I see this error in the browser - 'Cannot GET /about'

Both the home.html and about.html files are located in the same views directory.

Any help here would be very appreciated!

like image 681
Jared Avatar asked Aug 11 '16 22:08

Jared


2 Answers

let me quote from express doc:

A route will match any path that follows its path immediately with a “/”. For example: app.use('/apple', ...) will match “/apple”, “/apple/images”, “/apple/images/news”, and so on. see express doc

this is "not working" because you set the /about in the app.use and in the router.get. try to request /about/about and you will see that this is working (just not as you wanted to)..

now just change the /about in the routes/about.js then rerun and try to request /about and it will work :)

like image 88
Leibale Eidelman Avatar answered Nov 01 '22 03:11

Leibale Eidelman


Your route is set to /about/about. Change about.js to this:

const express = require('express');
const router = express.Router();

router.get('/', function(req, res) {
   res.render('app/about');
});

module.exports = router;
like image 12
Timmerz Avatar answered Nov 01 '22 03:11

Timmerz