Logo Questions Linux Laravel Mysql Ubuntu Git Menu
 

Naming a variable `current` in a kernel module leads to "function declaration isn’t a prototype" error

I'm learning to write kernel modules for linux as a beginner. What I'm trying to do is to write every task and its child process into the kernel log using DFS algorithm. But when I compile the code using Makefile, it shows the above error:

function declaration isn’t a prototype [-Werror=strict-prototypes]
struct task_struct *current;

It points out the task_struct keyword at the function DFS. Here's my code:

# include <linux/init.h>
# include <linux/kernel.h>
# include <linux/module.h>
# include <linux/sched.h>
# include <linux/list.h>

void DFS (struct task_struct *task)
{
    struct task_struct *current;
    struct list_head *list;

    list_for_each (list, &task->children)
    {
        current = list_entry(list, struct task_struct, sibling);
        printk(KERN_INFO "%d\t%d\t%s \n", (int)current->state, current->pid, current->comm);

        if (current != NULL)
        {
            DFS(current);
        }
    }
}

int DFS_init(void)
{
    printk(KERN_INFO "Loading the Second Module...\n");

    printk(KERN_INFO "State\tPID\tName\n");

    DFS(&init_task);   

    return 0;
}

void DFS_exit(void)
{
    printk(KERN_INFO "Removing the Second Module...\n");
}

Anyone knows how to fix this ??

like image 392
ThisaruG Avatar asked Aug 22 '15 15:08

ThisaruG


1 Answers

The kernel has a macro called current which is pointing to users currently executing process. As this book states,

The current pointer refers to the user process currently executing. During the execution of a system call, such as open or read, the current process is the one that invoked the call.

In other words, as @GilHamilton mentioned in the comments, current is #defined to the function get_current() in the kernel. Using current as a variable name will give a compile-time error!

like image 83
ThisaruG Avatar answered Sep 20 '22 15:09

ThisaruG