MVC3 Design - repository pattern and services layer [closed]

Question

I have read a couple of books and articles on MVC, and come across the repository pattern and the services layer.

Should a controller be able to get entities through the repository pattern, or must it retrieve data from the services layer?

Edit: I have code in the services layer that looks like this

public UserInfo GetModel(int userInfoID)
{
    return userInfoRepo.Get(userInfoID);
}

public UserInfo GetUserByPortalID(string portalID)
{
    return userInfoRepo.GetByPortalID(portalID);
}

public UserInfo GetModelByUserName(string username)
{
    return userInfoRepo.GetByUserName(username);
}

If a method in a service only calls another method in repository, is it necessary to have the controller go through the service?

Answer 1

In layered application architecture there's a fundamental rule that says that you must never bypass a layer. If you query your repository straight from your controller, you would be violating that rule.

So what? you may say. What if the service layer adds no value? Well, it might in the future...

You can choose to break the rule, but then it wouldn't be a layered application any more. That may be okay too - there are other good (even better) application architectures available, but I think that first you should make a decision regarding the overall architecture, and then you stick with that decision. Otherwise you'll end up with spaghetti code - we call it lasagna when it's a layered application :)