Multiple conditions in an if clause

Question

If I have an if statement that needs to meet these requirements:

if(cave > 0 && training > 0 && mobility > 0 && sleep > 0) 

Is there any way to say that all of them are bigger than zero? Just for more efficient DRY code?

Something like:

if(cave, training, mobility, sleep > 0) 

Answer 1

You could get the lowest value with Math.min, and then you only need one check against the lower bound.

if(Math.min(cave, training, mobility, sleep) > 0) {     //do something } 

Answer 2

You could use an array with .every. This is less DRY, but more verbose:

var isGreaterThanZero = function(val) {     return val > 0; }; if([cave, training, mobility, sleep].every(isGreaterThanZero)) {     // Do Something } 

The reason I like this is that by using an array, it becomes apparent that you're repeating logic for every variable. Naming the callback in an obvious manner helps future readers understand exactly what that check will achieve. And finally, this gives scope for not just numbers, but any check of any type in the future - with any complexity hidden away from the if statement itself.